Skip to content

Remove 2018 deprecated runtime contenttype extension point#1627

Closed
vogella wants to merge 1 commit intoeclipse-platform:masterfrom
vogellacompany:delete-deprecated-extension-point
Closed

Remove 2018 deprecated runtime contenttype extension point#1627
vogella wants to merge 1 commit intoeclipse-platform:masterfrom
vogellacompany:delete-deprecated-extension-point

Conversation

@vogella
Copy link
Contributor

@vogella vogella commented Nov 20, 2024

In 2018 we marked this extension point for deletion, lets remove it for 2025-03.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 20, 2024 •
edited
Loading

Test Results

0 files   -  1 755  0 suites   - 1 755   0s ⏱️ - 1h 37m 25s
0 tests  -  4 170  0 ✅  -  4 148  0 💤  -  22  0 ❌ ±0 
0 runs   - 13 107  0 ✅  - 12 943  0 💤  - 164  0 ❌ ±0 

Results for commit 73856e9. ± Comparison against base commit cf303ed.

♻️ This comment has been updated with latest results.

@eclipse-platform-bot
Copy link
Contributor

eclipse-platform-bot commented Nov 27, 2024

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

runtime/bundles/org.eclipse.core.runtime/META-INF/MANIFEST.MF
runtime/features/org.eclipse.core.runtime.feature/feature.xml

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch 
From a14bcbac31ec3df7687710829d750d49cd867829 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Wed, 27 Nov 2024 08:52:07 +0000
Subject: [PATCH] Version bump(s) for 4.35 stream


diff --git a/runtime/bundles/org.eclipse.core.runtime/META-INF/MANIFEST.MF b/runtime/bundles/org.eclipse.core.runtime/META-INF/MANIFEST.MF
index e23c69f6a9..1ef4c9aa7d 100644
--- a/runtime/bundles/org.eclipse.core.runtime/META-INF/MANIFEST.MF
+++ b/runtime/bundles/org.eclipse.core.runtime/META-INF/MANIFEST.MF
@@ -1,7 +1,7 @@
 Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
-Bundle-Version: 3.32.0.qualifier
+Bundle-Version: 3.32.100.qualifier
 Bundle-SymbolicName: org.eclipse.core.runtime; singleton:=true
 Bundle-Vendor: %providerName
 Bundle-Activator: org.eclipse.core.internal.runtime.PlatformActivator
diff --git a/runtime/features/org.eclipse.core.runtime.feature/feature.xml b/runtime/features/org.eclipse.core.runtime.feature/feature.xml
index 7ffa14238f..e21f0b592e 100644
--- a/runtime/features/org.eclipse.core.runtime.feature/feature.xml
+++ b/runtime/features/org.eclipse.core.runtime.feature/feature.xml
@@ -2,7 +2,7 @@
 <feature
       id="org.eclipse.core.runtime.feature"
       label="%featureName"
-      version="1.4.600.qualifier"
+      version="1.4.700.qualifier"
       provider-name="%providerName"
       license-feature="org.eclipse.license"
       license-feature-version="0.0.0">
-- 
2.47.0

Further information are available in Common Build Issues - Missing version increments.

@vogella
Copy link
Contributor Author

vogella commented Nov 27, 2024

@HannesWell I do not see the version increase commit from eclipse-platform-bot in this PR. Did I do something wrong? I will now rebase and see if the bot can add the version increase commit now.

@vogella
Remove 2018 deprecated runtime contenttype extension point
73856e9 
In 2018 we marked this extension point for deletion, lets remove it for
2025-03.
@eclipse-platform-bot
Copy link
Contributor

eclipse-platform-bot commented Nov 27, 2024

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

runtime/bundles/org.eclipse.core.runtime/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch 
From 214d2c652d388ce28fa3016541b2f6ce7cf64753 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Wed, 27 Nov 2024 17:02:34 +0000
Subject: [PATCH] Version bump(s) for 4.35 stream


diff --git a/runtime/bundles/org.eclipse.core.runtime/META-INF/MANIFEST.MF b/runtime/bundles/org.eclipse.core.runtime/META-INF/MANIFEST.MF
index e23c69f6a9..1ef4c9aa7d 100644
--- a/runtime/bundles/org.eclipse.core.runtime/META-INF/MANIFEST.MF
+++ b/runtime/bundles/org.eclipse.core.runtime/META-INF/MANIFEST.MF
@@ -1,7 +1,7 @@
 Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
-Bundle-Version: 3.32.0.qualifier
+Bundle-Version: 3.32.100.qualifier
 Bundle-SymbolicName: org.eclipse.core.runtime; singleton:=true
 Bundle-Vendor: %providerName
 Bundle-Activator: org.eclipse.core.internal.runtime.PlatformActivator
-- 
2.47.0

Further information are available in Common Build Issues - Missing version increments.

@HannesWell
Copy link
Member

HannesWell commented Nov 27, 2024

In 2018 we marked this extension point for deletion, lets remove it for 2025-03.

Have you checked if the extension-point is used anywhere in the SDK? I remember that quite a number of extensions for deprecated points exit.

@HannesWell I do not see the version increase commit from eclipse-platform-bot in this PR. Did I do something wrong? I will now rebase and see if the bot can add the version increase commit now.

The log of the publication workflow says that the bot is not permitted to push to your repository.
Have you disabled edits by maintainers?

@HannesWell HannesWell mentioned this pull request Nov 27, 2024
Closed
@vogella
Copy link
Contributor Author

vogella commented Nov 27, 2024

Have you disabled edits by maintainers?

No, but I learned from https://github.com/orgs/community/discussions/5634 that: if a PR is created from a fork living under an organisation (rather than an individual) it's not possible to allow edits by maintainers

So instead of sending PR from @vogellacompany I'm supposed to send them from @vogella to get this working. Thanks for the answer @HannesWell

@vogella
Copy link
Contributor Author

vogella commented Nov 27, 2024

New PR #1644

@vogella vogella closed this Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vogella @eclipse-platform-bot @HannesWell